Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support duration in ActiveSupport::XmlMini #51651

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

heka1024
Copy link
Contributor

Motivation / Background

Similar to #51631, ActiveSupport::XmlMini could not handle duration type in XML, which is one of primitive data type. ( https://www.w3.org/TR/xmlschema-2/#duration )

Detail

This Pull Request add duration parser and formatter on ActiveSupport::XmlMini, using ActiveSupport::Duration.

Additional information

https://www.w3.org/TR/xmlschema-2/#duration

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one change. Unrelated changes should be opened in separate PRs.
  • Commit message has a detailed description of what changed and why. If this PR fixes a related issue include it in the commit message. Ex: [Fix #issue-number]
  • Tests are added or updated if you fix a bug or add a feature.
  • CHANGELOG files are updated for the changed libraries if there is a behavior change or additional feature. Minor bug fixes and documentation changes should not be included.

@heka1024 heka1024 force-pushed the support-duration-in-xml branch 3 times, most recently from 15c314e to 750cbd3 Compare May 1, 2024 05:10
@flavorjones flavorjones added the ready PRs ready to merge label May 5, 2024
@flavorjones flavorjones added this to the 7.2.0 milestone May 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
activesupport ready PRs ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants