Refactor some comparison operators to avoid unnecessary blocks and

use of -1 and +1 "constants".
rakudo · Aug 6, 2010 · 035efb0 · 035efb0
1 parent 2c0ea31
commit 035efb0
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 9 deletions.
diff --git a/src/core/Cool-str.pm b/src/core/Cool-str.pm
@@ -424,11 +424,7 @@ our Str proto sub infix:<x>($str, $n) {
 }
 
 our multi sub infix:<cmp>($a, $b) {
-    if $a eq $b {
-        0;
-    } else {
-        $a lt $b ?? -1 !! 1;
-    }
+    $a lt $b ?? Order::Increase !! ($a gt $b ?? Order::Decrease !! Order::Same);
 }
 
 our multi sub infix:<leg>($a, $b) {

diff --git a/src/core/Numeric.pm b/src/core/Numeric.pm
@@ -288,19 +288,19 @@ multi sub infix:«!=»(Numeric $a, Numeric $b) {
 }
 
 multi sub infix:«<»(Numeric $a, Numeric $b) {
-    ($a <=> $b) == -1;
+    ($a <=> $b) < 0;
 }
 
 multi sub infix:«>»(Numeric $a, Numeric $b) {
-    ($a <=> $b) == +1;
+    ($a <=> $b) > 0;
 }
 
 multi sub infix:«<=»(Numeric $a, Numeric $b) {
-    ($a <=> $b) != +1;
+    ($a <=> $b) <= 0;
 }
 
 multi sub infix:«>=»(Numeric $a, Numeric $b) {
-    ($a <=> $b) != -1;
+    ($a <=> $b) >= 0;
 }
 
 multi sub srand(Numeric $seed) {