Add check for taints to determine if pod can run #29793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandond
requested changes
Oct 27, 2020
rmweir
force-pushed
the
worker-node-labels-v2
branch
from
2e3cae0
to
6caee3c
Compare
rmweir
force-pushed
the
worker-node-labels-v2
branch
from
6caee3c
to
1ecc906
Compare
cbron
reviewed
Oct 28, 2020
rmweir
force-pushed
the
worker-node-labels-v2
branch
from
1ecc906
to
f28e4e2
Compare
cbron
previously approved these changes
Oct 28, 2020
| if taint.Key != nodeRoleControlPlane && taint.Key != nodeRoleETCD && | ||
| taint.Key != nodeRoleControlPlaneHyphen && taint.Key != nodeRoleMaster { | ||
| continue | ||
| } |
There was a problem hiding this comment.
nit: feel like this is confusing conditional. You could do notWorker := a || b || c then if notWorker && taint == NoSchedule; return true
There was a problem hiding this comment.
@cbron Did something equivalent but without the inverted logic. Also, I try to avoid return the true case inside of conditionals as it's more idiomatic per: https://dave.cheney.net/2020/02/23/the-zen-of-go, but I think this reads fine now.
rmweir
force-pushed
the
worker-node-labels-v2
branch
from
f28e4e2
to
f0c84c2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version2 of: #29759
Problem
Even when some nodes are labelled as control plane, they still have the ability to run pods
Solution
Check for taints to determine if pods can be executed on that node and count it towards worker stats if it can
Issue
#29139