Enhance analyze command API to understand modules' needs #15011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Properly merge the contents of the grouping sets when combining sets of vulns. All permutations of simple double-transitive sets are now tested.
Some older modules don't have proper session type requirements. A sampling indicates they nearly always require meterpreter, so we can add this pending a metadata unification for those modules.
pbarry-r7
requested review from
erran-r7,
ebleiweiss-r7,
jmartin-tech and
adfoster-r7
|
Added folks as reviewers for visibility that this is posted up. Thanks! |
adfoster-r7
reviewed
May 7, 2021
adfoster-r7
reviewed
May 7, 2021
adfoster-r7
reviewed
May 7, 2021
adfoster-r7
reviewed
May 7, 2021
|
Looks good to me 👍 I can get this landed after the those last tweaks are in 🚢 |
adfoster-r7
reviewed
May 14, 2021
|
Imports and analyzing working: And sweet bonus UX improvements too 🎉 🙇♂️ With hosts but no vulns: Also confirmed what was discussed during module hacking - the speed is acceptable for a small number of hosts/vulns, but might need some tweaks to scale to larger data sets - but overall a great first step 👍 I think it's just that last line that needs a tweak then we can get this shipped 🚢 |
Release NotesEnhanced the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Beginning steps to enhance the
analyzecommand to be able to understand what potentially testable modules will need in order to run. Currently re-working vuln/service matching to lose less information. Putting more module option information in the module cache and/or having a step that instantiates good matches will likely be needed soon to provide better targeting.