-
Notifications
You must be signed in to change notification settings - Fork 13.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update rhost walker to handle interrupt signal #17409
Merged
jheysel-r7
merged 1 commit into
rapid7:master
from
adfoster-r7:update-rhost-walker-to-handle-interrupt-signal
Dec 28, 2022
Merged
Update rhost walker to handle interrupt signal #17409
jheysel-r7
merged 1 commit into
rapid7:master
from
adfoster-r7:update-rhost-walker-to-handle-interrupt-signal
Dec 28, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before
After
Spamming |
Release NotesUpdate rhost walker to handle interrupt signal |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the rhost walker to handle interrupt signals from the user when pressing
ctrl+c
in msfconsoleImproves #16765
Note that the
ctrl+c
interrupt signal won't be handled immediately - the DNS timeout will have to finish first. This seems like a bug in Ruby itself, where the the DNS resolve is blocking and the Ruby VM won't receive the interrupt signal until the DNS resolve timeout is hit - https://bugs.ruby-lang.org/issues/16476. So if the user spams ctrl+c, the multiple excess interrupt requests will bubble up after the DNS timeout ends - then msfconsole will be killed. Therefore the user will have to press ctrl+c once and wait patiently for invalid DNS requests to fail.Verification
Steps are in #16765