Add error handling when loading payloads #18220
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding in some error handling to payload loading so we don't crash msfconsole on boot as described here #18198 (note that the root cause of the issue described in #18198 is already addressed in #18171 where I borrowed some of this code from)
To replicate the original issue:
msfconsole
setg payload windows/x64/meterpreter/reverse_tcp
# This sets the payload datastore option globallyexit
and then restartmsfconsole
Verification Steps
msfconsole
no longer crashes on boot up with a globally set payload datastore option~/.msf4/logs/framework.log