Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix related modules references #18374

Merged
merged 4 commits into from Sep 20, 2023
Merged

Conversation

h00die
Copy link
Contributor

@h00die h00die commented Sep 15, 2023

#18351 (review)

Related Modules have to be within the Notes field. This moves any stragglers to where they should be, and adds a few missing fields within notes. This will fail lint as I didn't run rubocop because that's outside the scope of this PR

Verification

  • Start msfconsole
  • Pick a module which was altered
  • Verify run info and make sure you see a related module field

@adfoster-r7
Copy link
Contributor

CI is failing on syntax issues

     SyntaxError:
       /home/runner/work/metasploit-framework/metasploit-framework/modules/auxiliary/scanner/http/emby_version_ssrf.rb:26: syntax error, unexpected string literal, expecting ')'
             'References' => [
             ^

@cgranleese-r7 cgranleese-r7 self-assigned this Sep 18, 2023
@cgranleese-r7
Copy link
Contributor

cgranleese-r7 commented Sep 18, 2023

Everything seems to be working as expected 👍

  • admin/http/netgear_pnpx_getsharefolderlist_auth_bypass
  • admin/http/netgear_r6700_pass_reset
  • gather/pulse_secure_file_disclosure
  • scanner/http/emby_ssrf_scanner
  • scanner/http/emby_version_ssrf
  • windows/rdp/rdp_doublepulsar_rce
  • windows/smb/smb_doublepulsar_rce

@cgranleese-r7 cgranleese-r7 merged commit 37b506c into rapid7:master Sep 20, 2023
33 of 34 checks passed
@cgranleese-r7 cgranleese-r7 added enhancement rn-enhancement release notes enhancement labels Sep 20, 2023
@cgranleese-r7
Copy link
Contributor

cgranleese-r7 commented Sep 20, 2023

Release Notes

Fixes a bug in 7 modules which specified the RelatedModules metadata incorrectly. Now the RelatedModules data is correctly shown to the user when running the info command.

@h00die h00die deleted the fix_relatedmodules branch September 20, 2023 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement rn-enhancement release notes enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants