Add support for newer sqlcmd versions #18774
Conversation
| @@ -99,7 +99,7 @@ def check_osql | |||
| # @return [Boolean] true if sqlcmd is present | |||
| def check_sqlcmd | |||
| result = run_cmd('sqlcmd -?') | |||
| result =~ /SQL Server Command Line Tool/i | |||
| result =~ /SQL Server Command Line Tool|Version v\d+/i | |||
There was a problem hiding this comment.
For me, my ssqlcmd -? output only had the help menu and Version vx.y.z
| OptString.new('DB_USERNAME', [true, 'New sysadmin login', '']), | ||
| OptString.new('DB_PASSWORD', [true, 'Password for new sysadmin login', '']), | ||
| OptString.new('DB_USERNAME', [true, 'New sysadmin login', nil]), | ||
| OptString.new('DB_PASSWORD', [true, 'Password for new sysadmin login', nil]), |
There was a problem hiding this comment.
If you ran this module, the module would run with an empty db_username and db_password - which wouldn't work
There was a problem hiding this comment.
should the param not just be removed then, it's required so if we just don't give it one it should force you to set it right?
There was a problem hiding this comment.
I preferenced explicitness here
adfoster-r7
force-pushed
the
add-support-for-newer-sqlcmd-versions
branch
from
ada1307
to
5fa1ce8
Compare
|
Tested and looks good to me 👍
Note The errors I believe are because we're running from an account that isn't an admin in the database
|
Release NotesUpdates the following modules to now work with newer versions of |
Updates
post/windows/gather/credentials/mssql_local_hashdumpandpost/windows/manage/mssql_local_auth_bypassto work with newer versions of sqlcmdVerification
Ensure that these post modules work