Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert change to each_module for compatible nops #18828

Merged

Conversation

dwelch-r7
Copy link
Contributor

Resolves #18822

I accidentally replaced an each with an each_module in #18704 that shouldn't have been switched, I thought nops was a module set but it's just the return value of compatible_nops

Verification Steps

  • use multi/browser/chrome_cve_2021_21220_v8_insufficient_validation
  • run

Before:

msf6 > use multi/browser/chrome_cve_2021_21220_v8_insufficient_validation
[*] No payload configured, defaulting to linux/x64/meterpreter/reverse_tcp
msf6 exploit(multi/browser/chrome_cve_2021_21220_v8_insufficient_validation) > run

[-] Exploit failed: undefined method `each_module' for [["x64/simple", Msf::Modules::Nop__X64__Simple::MetasploitModule]]:Array
Did you mean?  each_slice
[*] Exploit completed, but no session was created.

After:

msf6 exploit(multi/browser/chrome_cve_2021_21220_v8_insufficient_validation) > run
[*] Exploit running as background job 0.
[*] Exploit completed, but no session was created.

[!] You are binding to a loopback address by setting LHOST to 127.0.0.1. Did you want ReverseListenerBindAddress?
[*] Started reverse TCP handler on 127.0.0.1:4444
msf6 exploit(multi/browser/chrome_cve_2021_21220_v8_insufficient_validation) > [*] Using URL: http://127.0.0.1:8080/gl9BOaXq
[*] Server started.

@adfoster-r7 adfoster-r7 merged commit 34a8b6c into rapid7:master Feb 13, 2024
49 checks passed
@adfoster-r7
Copy link
Contributor

Release Notes

Fixes a crash when exploit modules used nops

@smcintyre-r7 smcintyre-r7 added rn-fix release notes fix library bug labels Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug library rn-fix release notes fix
Projects
None yet
4 participants