New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds support for searching by session types #18887
Merged
adfoster-r7
merged 1 commit into
rapid7:master
from
cgranleese-r7:add-support-for-searching-by-session-type
Feb 29, 2024
Merged
Adds support for searching by session types #18887
adfoster-r7
merged 1 commit into
rapid7:master
from
cgranleese-r7:add-support-for-searching-by-session-type
Feb 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adfoster-r7
reviewed
Feb 26, 2024
@@ -399,6 +399,7 @@ def cmd_search_help | |||
'rank' => 'Modules with a matching rank (Can be descriptive (ex: \'good\') or numeric with comparison operators (ex: \'gte400\'))', | |||
'ref' => 'Modules with a matching ref', | |||
'reference' => 'Modules with a matching reference', | |||
'session_type' => 'Modules with a matching session type (SMB, MySQL, Meterpreter, etc)', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a blocker; SMB, MySQL, PostgresQL
probably should be behind a feature flag in the help message here
cgranleese-r7
force-pushed
the
add-support-for-searching-by-session-type
branch
3 times, most recently
from
February 27, 2024 15:33
d16a308
to
8be0a27
Compare
adfoster-r7
reviewed
Feb 27, 2024
adfoster-r7
reviewed
Feb 27, 2024
cgranleese-r7
force-pushed
the
add-support-for-searching-by-session-type
branch
3 times, most recently
from
February 28, 2024 13:02
71a65df
to
b1d7110
Compare
adfoster-r7
reviewed
Feb 28, 2024
adfoster-r7
reviewed
Feb 28, 2024
cgranleese-r7
force-pushed
the
add-support-for-searching-by-session-type
branch
4 times, most recently
from
February 29, 2024 09:40
e7ef814
to
7e0ce35
Compare
adfoster-r7
reviewed
Feb 29, 2024
cgranleese-r7
force-pushed
the
add-support-for-searching-by-session-type
branch
2 times, most recently
from
February 29, 2024 11:49
007d314
to
da17cf1
Compare
sjanusz-r7
reviewed
Feb 29, 2024
cgranleese-r7
force-pushed
the
add-support-for-searching-by-session-type
branch
from
February 29, 2024 15:15
da17cf1
to
0c1bcbf
Compare
Release NotesUpdates the search command to now search modules that are compatible with a specified session type, for instance: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support to the existing
search
command functionality to now also search by session type.The idea is to allow users to search by a specific session type and then a list of modules that support that session type will be output.
Tests were also updated for the new search functionality.
Note
This PR also adds support to the
help
command within sessions (MySQL, MSSQL, PostgreSQL and SMB) to now return a list off modules the current session type is compatible with.Meterpreter was excluded from this, as it's list would be much too long for this to work.
Verification
List the steps needed to make sure this thing works
msfconsole
search session_type:MySQL