Ensure modules honor spooler settings

[adfoster-r7]

Closes #18953

Verification

msfconsole
use auxiliary/scanner/ftp/ftp_version
run

Before

No error logs are output in the spooler file:

$ tail /tmp/example.txt
msf6 auxiliary(scanner/ftp/ftp_login) > run

[-] Msf::OptionValidateError One or more options failed to validate: RHOSTS.
msf6 auxiliary(scanner/ftp/ftp_login) >

After

Error logs are output to the spooler filter:

$ tail /tmp/example.txt
msf6 auxiliary(scanner/ftp/ftp_login) > run
msf6 auxiliary(scanner/ftp/ftp_login) >

[cgranleese-r7]

Msf::OptionValidateError errors are now spooled to the file correctly 👍

Before

msfconsole output

msf6 exploit(windows/smb/psexec) >  use auxiliary/scanner/ftp/ftp_version
msf6 auxiliary(scanner/ftp/ftp_version) > spool /tmp/example.txt
[*] Spooling to file /tmp/example.txt...
msf6 auxiliary(scanner/ftp/ftp_version) > set rhosts test.txt
rhosts => test.txt
msf6 auxiliary(scanner/ftp/ftp_version) > run

[-] test.txt:21           - Msf::OptionValidateError The following options failed to validate:
[-] test.txt:21           - Invalid option RHOSTS: Host resolution failed: test.txt
msf6 auxiliary(scanner/ftp/ftp_version) >

Spool output

metasploit-framework on  upstream-master:master [$?] via  desktop-linux via  v3.0.5 via ⍱
❯ tail -f /tmp/example.txt
[*] Spooling to file /tmp/example.txt...
msf6 auxiliary(scanner/ftp/ftp_version) > set rhosts test.txt
rhosts => test.txt
msf6 auxiliary(scanner/ftp/ftp_version) > ls
[*] exec: ls

msf6 auxiliary(scanner/ftp/ftp_version) > run
msf6 auxiliary(scanner/ftp/ftp_version) >

After

msfconsole output

msf6 exploit(windows/smb/psexec) > use auxiliary/scanner/ftp/ftp_version
msf6 auxiliary(scanner/ftp/ftp_version) > spool /tmp/example.txt
[*] Spooling to file /tmp/example.txt...
msf6 auxiliary(scanner/ftp/ftp_version) > set rhosts test.txt
rhosts => test.txt
msf6 auxiliary(scanner/ftp/ftp_version) > run

[-] test.txt:21           - Msf::OptionValidateError The following options failed to validate:
[-] test.txt:21           - Invalid option RHOSTS: Host resolution failed: test.txt
msf6 auxiliary(scanner/ftp/ftp_version) >

Spool output

metasploit-framework (4292488) [$?] via  desktop-linux via  v3.0.5 via ⍱ took 11s
❯ tail -f /tmp/example.txt
[*] Spooling to file /tmp/example.txt...
msf6 auxiliary(scanner/ftp/ftp_version) > set rhosts test.txt
rhosts => test.txt
msf6 auxiliary(scanner/ftp/ftp_version) > run

[-] test.txt:21           - Msf::OptionValidateError The following options failed to validate:
[-] test.txt:21           - Invalid option RHOSTS: Host resolution failed: test.txt
msf6 auxiliary(scanner/ftp/ftp_version) >

[cgranleese-r7]

Release Notes

This PR fixes an issue where modules were not honouring spooler settings.