Consistently refer to black hole as two words #18974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
Just before we lock things in; What was the rationale behind choosing two words for https://www.iana.org/help/dns-blackhole As well as Wikipedia:
Is there a semantic difference for Metasploit's implementation versus that definition? 👀 |
|
The rationale was that the actual phenomenon is spelled with two words. Also from Wikipedia: https://en.wikipedia.org/wiki/Black_hole Do you want it changed back to one word? |
|
Working for me, thanks! |
Release NotesFixes a typo in the help menu of the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a typo in the help menu of the
dnscommand.