Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add better logging for failed logins #19017

Merged
merged 1 commit into from Mar 28, 2024

Conversation

zgoldman-r7
Copy link
Contributor

@zgoldman-r7 zgoldman-r7 commented Mar 27, 2024

This adds more detailed error logging to failed runs of mssql_sql and mssql_exec modules, as previously it would just give a generic failed login error without providing the specific issue.
To reproduce, use mssql_sql module and try to connect with the database option set to something that isn't a real database.
New error:

[-] 192.168.2.131:1433 - Error with mssql_login call
[-] 192.168.2.131:1433 - SQL Server Error #4060 (State:1 Severity:11): Cannot open database "MSSQL" requested by the login. The login failed.
[-] 192.168.2.131:1433 - SQL Server Error #18456 (State:1 Severity:14): Login failed for user 'test'.

old:

[*] Running module against 192.168.2.131
[*] Auxiliary module execution completed

@zgoldman-r7 zgoldman-r7 marked this pull request as ready for review March 27, 2024 17:44
@adfoster-r7
Copy link
Contributor

Release Notes

Improves the auxiliary/admin/mssql/mssql_exec and auxiliary/admin/mssql/mssql_sql modules to have improved error logging

@adfoster-r7 adfoster-r7 merged commit 69660c3 into rapid7:master Mar 28, 2024
34 checks passed
@adfoster-r7 adfoster-r7 added the rn-enhancement release notes enhancement label Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rn-enhancement release notes enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants