Fixes password_spray not using additional_privates and default username's
#19156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adfoster-r7
reviewed
May 2, 2024
cgranleese-r7
force-pushed
the
fixes-password-spray-issues
branch
from
6420f64
to
d105ae1
Compare
Release NotesFixes a bug with the |
adfoster-r7
changed the title
password_spray not using additional_privates and default username'spassword_spray not using additional_privates and default username's
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes some issue that were found while working on another ticket.
The
password_spraydatastore option was not consideringadditional_privatesor defaultusernames.I have fixed these issues and added tests.
Verification
Currently a lot of the login modules have the
password_spraydatastore is currently being deregistered. (This is the ticket I am working on to change this)msfconsolepassword_sprayfromsmb_loginand test that way