Reimplement password_spray into login modules #19158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adfoster-r7
reviewed
May 3, 2024
lib/metasploit/framework/login_scanner/configure_login_scanner.rb
Outdated
Show resolved
Hide resolved
adfoster-r7
reviewed
May 3, 2024
lib/metasploit/framework/login_scanner/configure_login_scanner.rb
Outdated
Show resolved
Hide resolved
cgranleese-r7
force-pushed
the
fixes-password-spray-issues
branch
from
cc8d1ce
to
f8319f0
Compare
adfoster-r7
reviewed
May 3, 2024
adfoster-r7
reviewed
May 3, 2024
cgranleese-r7
changed the title
cgranleese-r7
force-pushed
the
fixes-password-spray-issues
branch
from
f8319f0
to
bb473f4
Compare
Release NotesUpdates multiple login modules to support the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates login scanner modules to support
PASSWORD_SPRAY. We updated the existing modules no longer deregister thePASSWORD_SPRAYmodule option.I added a base configure scanner method for binding common datastore options to the login scanners, similar to the HTTP implementations.
I updated the existing
configure_http_login_scannerimplementation to call off to the new genericconfigure_login_scannerimplementation, so that theconfigure_http_login_scannermethod gets any new options that we add in the future for free.Verification
password_spraynow works as intended