Update gemspec to use require relative #19200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release NotesUpdates Metasploit's gemspec file to work with additional static analysis tools |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update gemspec to use require relative, so that it can be used with external static analysis tools
I believe this will fix the following dependabot update issue of not being able to auto-generate update PRs:
As under the hood, only the first level of require_relative expressions are fetched and loaded by dependabot according to this comment: dependabot/feedback#393 (comment) and implementation: https://github.com/dependabot/dependabot-core/blob/13bf8117e4d1731a64a3d2bf8d1f56a000b4bfb0/bundler/lib/dependabot/bundler/file_fetcher.rb#L143-L154
Verification