Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporary fix to restore rspec progress formatter #474

Merged
merged 1 commit into from
Aug 29, 2022

Conversation

mkienow-r7
Copy link
Contributor

@mkienow-r7 mkienow-r7 commented Aug 29, 2022

Description

A temporary fix to restore the rspec progress formatter. spec/spec_helper.rb contains a configuration to modify the formatter to documentation when an individual file is specified, however, after the repository split the repo only contains the single spec spec/lib/fingerprint_self_test_spec.rb. This change should be undone when another spec is introduced.

Motivation and Context

Restore expected rspec behavior for previous committers.

How Has This Been Tested?

  • rake tests
  • bundle exec rspec

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have updated the documentation accordingly (or changes are not required).
  • I have added tests to cover my changes (or new tests are not required).
  • All new and existing tests passed.

Copy link
Contributor

@TomSellers TomSellers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sorting this out!

Copy link

@egalinkin-r7 egalinkin-r7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as a temp fix

@mkienow-r7 mkienow-r7 merged commit 8383440 into rapid7:main Aug 29, 2022
@mkienow-r7 mkienow-r7 deleted the bug/restore-rspec-progress branch August 29, 2022 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants