Refactor VIP_SCRIPT checking #8144
Open
+97
−54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vstumpf
force-pushed
the
refactor/vip_script
branch
from
37e0a3b
to
223e294
Compare
sammeepay
added a commit
to sammeepay/rathena-edit-custom-npcthai
that referenced
this pull request
Feb 24, 2024
Lemongrass3110
requested changes
Feb 26, 2024
| @@ -30,7 +30,7 @@ | |||
| export_constant(MAX_GUILD_STORAGE); | |||
| export_constant(MAX_BG_MEMBERS); | |||
| export_constant(MAX_CHAT_USERS); | |||
| export_constant(VIP_SCRIPT); | |||
| export_deprecated_constant(VIP_SCRIPT); | |||
There was a problem hiding this comment.
We could sync the constant with the config value.
Then this PR would become a lot smaller and would enable your desired changes as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When these vip options become configuration, the values of the script constants would change. Since we can't change the value of these constants, we should instead call a function. Right now, it still uses compile-time definitions, but eventually we can change it to pull from a configuration.