Use UUID directly for generating session IDs

ratpack · Apr 23, 2019 · f2b63eb · erdi · Apr 23, 2019 · ldaley
1 parent 259717a
commit f2b63eb
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/ratpack-session/src/main/java/ratpack/session/SessionModule.java b/ratpack-session/src/main/java/ratpack/session/SessionModule.java
@@ -194,6 +194,7 @@ SessionStore sessionStoreAdapter(@Named(LOCAL_MEMORY_SESSION_CACHE_BINDING_NAME)
   }
 
   @Provides
+  @Singleton
   SessionIdGenerator sessionIdGenerator() {
     return new DefaultSessionIdGenerator();
   }

diff --git a/ratpack-session/src/main/java/ratpack/session/internal/DefaultSessionIdGenerator.java b/ratpack-session/src/main/java/ratpack/session/internal/DefaultSessionIdGenerator.java
@@ -16,18 +16,17 @@
 
 package ratpack.session.internal;
 
+import com.google.inject.Singleton;
 import io.netty.util.AsciiString;
 import ratpack.session.SessionIdGenerator;
 
 import java.util.UUID;
-import java.util.concurrent.ThreadLocalRandom;
 
+@Singleton
 public class DefaultSessionIdGenerator implements SessionIdGenerator {
 
   public AsciiString generateSessionId() {
-    ThreadLocalRandom random = ThreadLocalRandom.current();
-    UUID uuid = new UUID(random.nextLong(), random.nextLong());
-    return AsciiString.of(uuid.toString());
+    return AsciiString.cached(UUID.randomUUID().toString());
   }
 
 }