Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require Julia 1.0 #17

Merged
merged 1 commit into from Dec 3, 2018
Merged

Require Julia 1.0 #17

merged 1 commit into from Dec 3, 2018

Conversation

dnk8n
Copy link
Contributor

@dnk8n dnk8n commented Oct 26, 2018

I didn't know the syntax to enable the ability for the package to install on both 0.6* and 1.0*

Just thought I would show that this does correctly install on 1.0 and only the REQUIREMENTS file needs changing.

Here is a screenshot of the current stable version of the package on Julia 1.0 failing, and then the version with my amendment passing

screencapture-galaxy-hivdv-uct-ac-za-8010-notebooks-test_levenshtein-ipynb-2018-10-26-10_00_00

Merging this would solve #16 but might break current 0.6 installation. Not sure what needs to be done to support both. I have never worked with Julia in a substantial way before.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling dcc1c2d on cape-diff:master into 92586fe on rawrgrr:master.

@dnk8n
Copy link
Contributor Author

dnk8n commented Oct 26, 2018

Coverage Status

Coverage remained the same at 100.0% when pulling dcc1c2d on cape-diff:master into 92586fe on rawrgrr:master.

Would need the automation servers to be on Julia 1.0 to test whether this all works. Is that all configurable via the code in this repo?

So to-do list for this PR:

  • Specify REQUIREMENTS so that it works 0.64 - 1.0 (this undertaking might be far too much work. So better to choose one for now IMO.
  • If you choose to stay with 0.64, then I can look into incorporating the same automation as you into my fork rather (except Julia 1.0) and have it working on 1.0 there.

Comments on how you want to proceed. And if you could aid me to get my CI working like yours, that would be great.

@rawrgrr rawrgrr merged commit 8c7765a into rawrgrr:master Dec 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants