Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pushable with Typescript #755

Closed
cxii112 opened this issue Mar 14, 2021 · 4 comments · May be fixed by #782
Closed

Pushable with Typescript #755

cxii112 opened this issue Mar 14, 2021 · 4 comments · May be fixed by #782

Comments

@cxii112
Copy link

cxii112 commented Mar 14, 2021

I tried to use pushable range. When I tried to set pushable to number I get:

Type "number" is not assignable to parameter of type "boolean | undefined"

Same thing when I tried use RangeProps. So I changed pushable?: boolean; in Range.d.ts to pushable?: boolean | number; and it works fine.
Am I doing right (I'm new to development, sorry)?

I'm using:
Typescript 4.1.2
React 17.0.1
rc-slider 9.7.1
@TomlDev
Copy link

TomlDev commented Apr 27, 2021

Bump 👍🏽

@lucasbordeau lucasbordeau mentioned this issue Jun 18, 2021
Open
@akash10agarwal
Copy link

@cxii112 @TomlDev pls point to the ver which contains this fix?

@cxii112
Copy link
Author

cxii112 commented Feb 7, 2022

@akash10agarwal i have tested on ^9.7.5 rn. it works fine.

@cxii112 cxii112 closed this as completed Feb 7, 2022
@akash10agarwal
Copy link

thanks worked. still seems to have lots of open issues as can be seen here in the Issues tab for this Github prj. is there a stable ver?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(range): fixed pushable prop typing lucasbordeau/slider
3 participants
@akash10agarwal @TomlDev @cxii112