Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(range): fixed pushable prop typing #782

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lucasbordeau
Copy link

Added a number type on pushable property of Range component to reflect the real behavior of this property.

See documentation : https://github.com/react-component/slider#range

Fixes #755 and #654

@vercel
Copy link

vercel bot commented Jun 18, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/react-component/slider/4CxNqp1wv4JCQCR9JXo44U1shdyy
✅ Preview: https://slider-git-fork-lucasbordeau-fix-range-p-2432ac-react-component.vercel.app

@fatso83
Copy link

fatso83 commented Nov 16, 2021

How is this not being merged by now? Same as #725 and #713 which fixed #654

@yoyo837
Copy link
Member

yoyo837 commented Apr 15, 2023

conflicted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pushable with Typescript
3 participants