fix(allowCross): When two handles coincide (i.e pushNum = 0 || pushab… #904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…le = false, allowCross === false ) and you can move the handle across the other handle which should not be the case
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Please add some test case for it. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #904 +/- ##
===========================================
- Coverage 100.00% 99.46% -0.54%
===========================================
Files 13 13
Lines 558 565 +7
Branches 169 164 -5
===========================================
+ Hits 558 562 +4
- Misses 0 3 +3 ☔ View full report in Codecov by Sentry. |
Please add some test case for it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…le = false, allowCross === false ) and you can move the handle across the other handle which should not be the case