New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Have all project declare an explicit Java9 Automatic Module Name #667
Comments
Choosing an
|
Split PackagesThe JPMS enforces that no two modules can export the same package. This is for classes that are directly in said packages, so However there are at least a couple of projects where there is room for improvement in terms of packages: a more specific "root" package would be better:
|
Module Names Proposal 1*Rejected*
Please vote/comment @smaldini @violetagg @bsideup |
Do we really need to duplicate "reactor" in it? |
Good point, there is only blockhound that doesn't have the reactor prefix, so we can remove it in module names I guess 👍. Will edit the proposal above. |
Module Names Proposal 2
Please vote/comment @smaldini @violetagg @bsideup |
@simonbasle Reactor RabbitMQ already uses |
To be more Jigsaw friendly, we should clearly define the top level package for each Reactor's sub-project. `reactor.BlockHound` class breaks this, and should be moved to a dedicated package (`reactor.blockhound`) See reactor/reactor#667
To be more Jigsaw friendly, we should clearly define the top level package for each Reactor's sub-project. `reactor.BlockHound` class breaks this, and should be moved to a dedicated package (`reactor.blockhound`) See reactor/reactor#667
This includes tools and samples artifacts. See reactor/reactor#667
This includes tools and samples artifacts. See reactor/reactor#667
This includes tools and samples artifacts. See reactor/reactor#667
The Automatic Module feature has 2 modes in terms of how it choses the generated module's name:
MANIFEST.MF
as anAutomatic-Module-Name
attribute.The later solution is more stable, but makes the module name part of the API: this is basically a pledge to use that module name later on when explicit modularization is introduced. Note that changing the module name is not a light thing: every dependent modularized code will need to be updated to
requires
the new module name.This epic is two-parts: choosing a name pattern for the projects and making sure no same package is split between two "modules".
The text was updated successfully, but these errors were encountered: