Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Declare an Java9 JPMS Automatic-Module-Name for core and test #1692

Merged
merged 1 commit into from
May 6, 2019

Conversation

simonbasle
Copy link
Member

@simonbasle simonbasle added this to the 3.3.0.M1 milestone May 6, 2019
@codecov-io
Copy link

codecov-io commented May 6, 2019

Codecov Report

Merging #1692 into master will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1692      +/-   ##
============================================
+ Coverage     84.35%   84.39%   +0.04%     
- Complexity     3931     3933       +2     
============================================
  Files           362      362              
  Lines         30048    30048              
  Branches       5590     5590              
============================================
+ Hits          25347    25360      +13     
+ Misses         3084     3082       -2     
+ Partials       1617     1606      -11
Impacted Files Coverage Δ Complexity Δ
...va/reactor/core/publisher/ParallelMergeReduce.java 69.42% <0%> (-3.31%) 3% <0%> (ø)
...c/main/java/reactor/core/publisher/FluxReplay.java 84.31% <0%> (+0.15%) 25% <0%> (ø) ⬇️
...ain/java/reactor/core/publisher/FluxPublishOn.java 86.59% <0%> (+0.2%) 6% <0%> (ø) ⬇️
...c/main/java/reactor/core/publisher/FluxCreate.java 86.26% <0%> (+0.24%) 8% <0%> (ø) ⬇️
.../main/java/reactor/core/publisher/FluxFlatMap.java 94.78% <0%> (+0.38%) 13% <0%> (ø) ⬇️
...ava/reactor/core/publisher/EventLoopProcessor.java 80.82% <0%> (+0.51%) 53% <0%> (+1%) ⬆️
...main/java/reactor/core/publisher/FluxGenerate.java 82.2% <0%> (+0.61%) 7% <0%> (ø) ⬇️
...java/reactor/core/scheduler/ExecutorScheduler.java 79.86% <0%> (+0.69%) 12% <0%> (ø) ⬇️
...java/reactor/core/publisher/FluxFirstEmitting.java 75.18% <0%> (+0.72%) 8% <0%> (ø) ⬇️
.../java/reactor/core/publisher/BlockingIterable.java 78.12% <0%> (+1.04%) 7% <0%> (ø) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a137fa...2ce6f00. Read the comment docs.

@simonbasle simonbasle merged commit f8a2dac into master May 6, 2019
@simonbasle simonbasle deleted the java9-moduleName branch May 6, 2019 21:13
simonbasle added a commit that referenced this pull request May 14, 2020
This includes:
 - using local buildSrc plugins rather than adhoc code blocks (detecting
 ci, java conventions, custom version)
 - splitting out javadoc/asciidoc gradle files
 - fixing the directory into which asciidocs are built
 - avoid building pdf reference guide locally (unless release)
 - remove spring-io-plugin / platform
 - bump asciidoctor.convert plugin
 - micrometer version defined in gradle.properties and pinned
 - reactiveStream version defined in gradle.properties
 - junit, awaitility, jol and testNg versions defined in properties
 rather than inline
 - use gradle enterprise plugin for buildScan
 - removed hamcrest-library dependency
 - automatic module names (see #1692)

The shadow plugin has been removed in 3.2.x but will be reintroduced
in 3.3.x
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants