[DRWTSN32] Initial rough implementation #145

learn-more · 2017-11-25T20:29:05Z

Purpose

This aims to add a rough sketch of how drwtsn32 could look like.
DrWtsn32 is a crash reporter.

TODO

Figure out why the stacktrace does not work
Output to a file (on the desktop?) instead of stdout.
Figure out how to get the correct exception, instead of the attach breakpoint.
Notify the user about the stacktrace dumped on the desktop.
Disassemble the offending function (maybe move the kdb disassembler into a library?)

HBelusca · 2017-11-25T20:52:23Z

\o/
You should also ask @encodedpr what the status of his crash-reporter is.

HBelusca · 2017-11-25T20:52:48Z

base/applications/drwtsn32/CMakeLists.txt

+
+set_cpp(WITH_RUNTIME WITH_EXCEPTIONS WITH_STL)
+
+


Extra newline

HBelusca · 2017-11-25T20:53:14Z

base/applications/drwtsn32/drwtsn32.cpp

@@ -0,0 +1,118 @@
+#include "precomp.h"


Missing code source copyright header.

HBelusca · 2017-11-25T20:54:19Z

base/applications/drwtsn32/drwtsn32.cpp

+    case CREATE_PROCESS_DEBUG_EVENT:
+    {
+        data.ProcessPath.resize(MAX_PATH);
+        DWORD len = GetModuleFileNameExA(evt.u.CreateProcessInfo.hProcess, NULL, &data.ProcessPath[0], data.ProcessPath.size());


What about using UNICODE everywhere?
But then the STL stuff should be like std::wstring & co.
Unless you want to use ATL?

Eventually I want to print this to a file instead of stdout, and then UNICODE is not really convenient.

encodedpr · 2017-11-26T04:37:10Z

Status = STATUS_NOTHING

yagoulas · 2017-11-27T13:13:14Z

Here is the code of the logger I'm working on based on your code. I want it to be able to log a backtrace for the exceptions it may encounter so in the end the two will share a lot of code:

https://github.com/yagoulas/reactos/blob/roslogger/base/applications/roslogger/roslogger.cpp

Mouvedia · 2017-12-16T02:27:30Z

Please don't add an unique identifier.
cf https://www.schneier.com/blog/archives/2017/08/nsa_collects_ms.html

HBelusca · 2017-12-16T02:33:24Z

@Mouvedia , you are completely out of topic. That spying thingie is when reports are sent onto the internet to MS. Here the PR is about just a mere post-mortem debugger.

Mouvedia · 2017-12-16T02:36:54Z

@HBelusca if you are planning to send the crash reports sometime in the future it will become relevant.

ThFabba · 2017-12-16T08:48:57Z

It's a valid concern, although not for the current implementation.
However the "unique identifier" that article talks about is the IP address. It's, uhm... pretty hard to send things on the internet without including that.
Also, end-to-end encryption mitigates this problem, as the article also mentions.

Mouvedia · 2017-12-16T12:55:51Z

However the "unique identifier" that article talks about is the IP address.

I was talking about HKEY_LOCAL_MACHINE\Software\Microsoft\Cryptography\MachineGuid.
The IP can be dynamic, it's less critical.

gigaherz · 2017-12-16T13:09:08Z

What does the MachineGuid registry key have to do with this? This is a drwatson PR, implementing a debugging tool. That key is used exclusively by the cryptographic components.

learn-more · 2017-12-16T13:12:44Z

Please keep your tin foil hat BS out of this PR, thanks.

fix module name printing, bail out on a too long stacktrace, drop crashdump on the desktop.

Fix output of version, fix infinite loops in the stackwalk

learn-more · 2017-12-29T17:00:00Z

The disassembly of the offending function will be added later, I want to go ahead and get this in.
Please review.

(After reviewing, all commits will be squashed to one)

HeisSpiter · 2017-12-29T17:17:48Z

base/applications/drwtsn32/drwtsn32.cpp

+                    return true;
+                }
+                break;
+            case 0x406d1388:


Magic value

Fair enough :)

On application crash, drwtsn32 will attach to the application and try to get a dump, consisting of: - List of loaded modules - List of loaded threads - Per thread, a stacktrace - Per thread, a small hexdump from the stack - Per thread, a dump of the most common registers This dump is saved to the desktop, and the user is notified of the dump being dropped there. CORE-14180 reactos#145

learn-more added the WIP label Nov 25, 2017

HBelusca reviewed Nov 25, 2017

View reviewed changes

base/applications/drwtsn32/CMakeLists.txt Outdated

set_cpp(WITH_RUNTIME WITH_EXCEPTIONS WITH_STL)

Copy link

Contributor

HBelusca Nov 25, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra newline

HBelusca reviewed Nov 25, 2017

View reviewed changes

base/applications/drwtsn32/drwtsn32.cpp

@@ -0,0 +1,118 @@

#include "precomp.h"

Copy link

Contributor

HBelusca Nov 25, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing code source copyright header.

HBelusca reviewed Nov 25, 2017

View reviewed changes

learn-more force-pushed the drwtsn branch from 1583ef3 to e5d785d Compare November 26, 2017 00:46

ThFabba assigned learn-more Dec 8, 2017

learn-more force-pushed the drwtsn branch from c6a7d47 to 1b27cfb Compare December 16, 2017 14:03

learn-more added 6 commits December 29, 2017 17:57

[DRWTSN32] Initial rough implementation

0c7af50

Add license headers

18226eb

Fix a clang warning

ffc7010

Also include the initial thread,

3188b5c

fix module name printing, bail out on a too long stacktrace, drop crashdump on the desktop.

Grab the actual exception by kicking the event,

c3c955a

Fix output of version, fix infinite loops in the stackwalk

Notify the user about the crash dump.

d8c93c7

learn-more force-pushed the drwtsn branch from 1b27cfb to d8c93c7 Compare December 29, 2017 16:57

learn-more removed the WIP label Dec 29, 2017

HeisSpiter requested changes Dec 29, 2017

View reviewed changes

magic--

54e275e

learn-more merged commit 280d7a9 into reactos:master Jan 6, 2018

learn-more deleted the drwtsn branch January 6, 2018 10:47

julenuri added a commit to julenuri/reactos that referenced this pull request Dec 9, 2023

Add Calibre 2.0.0 to the Rapps-db in x86/AMD64 (reactos#145)

d4b8b5d

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[DRWTSN32] Initial rough implementation #145

[DRWTSN32] Initial rough implementation #145

learn-more commented Nov 25, 2017 •

edited

HBelusca commented Nov 25, 2017

HBelusca Nov 25, 2017

HBelusca Nov 25, 2017

HBelusca Nov 25, 2017

learn-more Nov 25, 2017

encodedpr commented Nov 26, 2017

yagoulas commented Nov 27, 2017

Mouvedia commented Dec 16, 2017

HBelusca commented Dec 16, 2017

Mouvedia commented Dec 16, 2017 •

edited

ThFabba commented Dec 16, 2017

Mouvedia commented Dec 16, 2017 •

edited

gigaherz commented Dec 16, 2017

learn-more commented Dec 16, 2017

learn-more commented Dec 29, 2017

HeisSpiter Dec 29, 2017

learn-more Dec 29, 2017

[DRWTSN32] Initial rough implementation #145

[DRWTSN32] Initial rough implementation #145

Conversation

learn-more commented Nov 25, 2017 • edited

Purpose

TODO

HBelusca commented Nov 25, 2017

HBelusca Nov 25, 2017

Choose a reason for hiding this comment

HBelusca Nov 25, 2017

Choose a reason for hiding this comment

HBelusca Nov 25, 2017

Choose a reason for hiding this comment

learn-more Nov 25, 2017

Choose a reason for hiding this comment

encodedpr commented Nov 26, 2017

yagoulas commented Nov 27, 2017

Mouvedia commented Dec 16, 2017

HBelusca commented Dec 16, 2017

Mouvedia commented Dec 16, 2017 • edited

ThFabba commented Dec 16, 2017

Mouvedia commented Dec 16, 2017 • edited

gigaherz commented Dec 16, 2017

learn-more commented Dec 16, 2017

learn-more commented Dec 29, 2017

HeisSpiter Dec 29, 2017

Choose a reason for hiding this comment

learn-more Dec 29, 2017

Choose a reason for hiding this comment

learn-more commented Nov 25, 2017 •

edited

Mouvedia commented Dec 16, 2017 •

edited

Mouvedia commented Dec 16, 2017 •

edited