Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Data Version Control tutorial materials #132

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

kivancic-ut
Copy link

Where to put new files:

  • New files should go into a top-level subfolder, named after the article slug. For example: my-awesome-article

How to merge your changes:

  1. Make sure the CI code style tests all pass (+ run the automatic code formatter if necessary).
  2. Find an RP Team member on Slack and ask them to review & approve your PR.
  3. Once the PR has one positive ("approved") review, GitHub lets you merge the PR.
  4. 🎉

Copy link
Contributor

@somacdivad somacdivad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @KristijanIvancic!

I've left you some feedback on the code. For the most part everything is good, I just have a few suggestions to clean a few things up and maybe simplify a few lines.

Let me know what you think!

python-data-version-control/src/evaluate.py Outdated Show resolved Hide resolved
python-data-version-control/src/evaluate.py Outdated Show resolved Hide resolved
python-data-version-control/src/evaluate.py Outdated Show resolved Hide resolved
python-data-version-control/src/evaluate.py Outdated Show resolved Hide resolved
python-data-version-control/src/prepare.py Outdated Show resolved Hide resolved
python-data-version-control/src/prepare.py Outdated Show resolved Hide resolved
python-data-version-control/src/prepare.py Outdated Show resolved Hide resolved
python-data-version-control/src/prepare.py Outdated Show resolved Hide resolved
python-data-version-control/src/prepare.py Outdated Show resolved Hide resolved
python-data-version-control/src/train.py Outdated Show resolved Hide resolved
@somacdivad
Copy link
Contributor

@KristijanIvancic I've approved the PR. No need to merge it or anything. An editor will take care of that before the article goes live!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants