Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A place for simple web applications #478

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

A place for simple web applications #478

wants to merge 7 commits into from

Conversation

Abdull216
Copy link

Where to put new files:

  • New files should go into a top-level subfolder, named after the article slug. For example: my-awesome-article

How to merge your changes:

  1. Make sure the CI code style tests all pass (+ run the automatic code formatter if necessary).
  2. Find an RP Team member on Slack and ask them to review & approve your PR.
  3. Once the PR has one positive ("approved") review, GitHub lets you merge the PR.
  4. 🎉

@writeson
Starting to change the JavaScript SPA code to use native JavaScript i…
e906863 
…nstead of jQuery, Handlebars and Moment
@writeson
Re-wrote the JavaScript code for all three SPA's to use native JavaSc…
ec63908 
…ript rather than jQuery, etc. This is the result, which works! Also, centralized some of the CSS code under the parent.css file.
@writeson
Made changes based on Dan's comments, mostly formating and naming con…
cc0ef19 
…vention changes
@writeson
Simplified the CSS files across the board, and replaced with `parseIn…
0aafb92 
…t()` function with a simple `+`, as that's all that's needed to convert a string to an integer. Also clarified the namespace importing.
@writeson
Changed the beginning character of some comments to begin with an upp…
155f59a 
…ercase character.
@writeson
Changed the beginning character of some comments to begin with an upp…
26b6e49 
…ercase character, again... :)
@writeson
Changed the beginning character of some comments to begin with an upp…
5f49d84 
…ercase character, again... :)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Abdull216 @writeson