Skip to content
This repository has been archived by the owner on Nov 9, 2017. It is now read-only.

The Code Salon

Jump to bottom
Jim Cruz-Youll edited this page Jul 17, 2017 · 3 revisions

We use the entirely made up Code Salon Review Method™. This consists of a few emoji that we use to indicate states of the review process. Those emoji are, in roughly the order they'd be seen in review:

If using the emojis below, they must be entered into a free-standing comment, not in a reply to a comment. This way, the bot will notice them and post a notification to in the appropriate "salon" to tell reviewers to take another look.

  • nail care 💅
    :nail_care:

    by a reviewer: "I've finished my review pass and am awaiting your responses."

  • haircut 💇
    :haircut:

    by the author: "I've responded or made appropriate changes and am ready for further review." Tip: don't 💇 individual reviews. Finally an entire review pass, then enter 💇 into a new comment on the PR (not a reply).

  • fish 🐟
    :fish:

    by a reviewer: "I think this pull request is ready for merging."

Internal Use Only

  • eyeglasses 👓
    :eyeglasses:

    followed by a list of @github-username mentions: "[mentioned users] please review this pull request"

  • running 🏃
    :running:

    by a reviewer: "I don't have time to review this at the moment, please find someone else."

  • no bell 🔕
    :no_bell:

    by a reviewer: "This is just a comment and requires no action."

The bot that runs in the #salon and #salon-* Slack channels will announce to the channel any time these symbols are used during review of a pull request. This helps remind us that there's stuff to do. You'll probably see us use these symbols during review of your pull requests. Please feel free to use the appropriate ones in response.

Where did this all come from, you ask? Truth be told, it's pretty much just a random smattering of emoji that we cobbled together over time.

Clone this wiki locally