Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change packaging for macOS to DMG #1353

Merged
merged 2 commits into from Apr 10, 2018

Conversation

dgolovin
Copy link
Contributor

@dgolovin dgolovin commented Apr 3, 2018

Fix #1158 .

@codecov-io
Copy link

codecov-io commented Apr 3, 2018

Codecov Report

Merging #1353 into master will decrease coverage by 1.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1353      +/-   ##
==========================================
- Coverage   93.25%   92.22%   -1.03%     
==========================================
  Files          47       47              
  Lines        4847     4966     +119     
  Branches      543      864     +321     
==========================================
+ Hits         4520     4580      +60     
- Misses        327      357      +30     
- Partials        0       29      +29
Impacted Files Coverage Δ
browser/pages/start/controller.js 81.2% <0%> (-18.8%) ⬇️
browser/model/devstudio-autoinstall.js 97.29% <0%> (-2.71%) ⬇️
browser/pages/install/controller.js 91.86% <0%> (-1.75%) ⬇️
browser/model/helpers/downloader.js 95.53% <0%> (-1.68%) ⬇️
browser/model/che.js 95% <0%> (-1.62%) ⬇️
browser/services/platform.js 98.14% <0%> (-1.48%) ⬇️
browser/pages/account/controller.js 98.61% <0%> (-1.39%) ⬇️
browser/model/cdk.js 97.6% <0%> (-1.16%) ⬇️
browser/model/devstudio-p2-zip.js 64.4% <0%> (-1.12%) ⬇️
browser/model/installable-item.js 92.28% <0%> (-1.03%) ⬇️
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b70b8a8...ff8c52a. Read the comment docs.

@dgolovin dgolovin changed the title [WIP] Change packaging for mac to DMG Change packaging for mac to DMG Apr 3, 2018
@jrichter1
Copy link
Collaborator

jrichter1 commented Apr 3, 2018

Looks like no functionality gets broken by this (yay), so I'm trying to sum up what else would need to be changed (meh). So far I got this (anything missing?):

  • the build job (the publishing part)
  • docs RHDEVDOCS-727
  • some of my scripts (which I can live with)

So if all the parties involved get updated, it should be good to go.

@dgolovin
Copy link
Contributor Author

dgolovin commented Apr 3, 2018

@jrichter1 We should put our build script to git as well, so we can fix them at the same time.

@dgolovin
Copy link
Contributor Author

dgolovin commented Apr 3, 2018

@jrichter1 this also opens opportunity to create shell script or app to uninstall on mac and put it next to installer inside dmg.

@dgolovin dgolovin changed the title Change packaging for mac to DMG Change packaging for macOS to DMG Apr 4, 2018
Fix changes packaging to dmg for mac and updates README.md to mention new format for macOS installers.
@dgolovin
Copy link
Contributor Author

@jrichter1 I've tested installation for bundled installer and it worked for me, should we merge this PR?

@dgolovin dgolovin requested a review from jrichter1 April 10, 2018 03:57
@jrichter1
Copy link
Collaborator

It seems I'll need to change the way system tests launch on mac. I'm going to push it here and that should be enough to merge.

@jrichter1
Copy link
Collaborator

looks like we are good to go

@jrichter1 jrichter1 merged commit 8461b40 into redhat-developer-tooling:master Apr 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants