New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change packaging for macOS to DMG #1353
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1353 +/- ##
==========================================
- Coverage 93.25% 92.22% -1.03%
==========================================
Files 47 47
Lines 4847 4966 +119
Branches 543 864 +321
==========================================
+ Hits 4520 4580 +60
- Misses 327 357 +30
- Partials 0 29 +29
Continue to review full report at Codecov.
|
Looks like no functionality gets broken by this (yay), so I'm trying to sum up what else would need to be changed (meh). So far I got this (anything missing?):
So if all the parties involved get updated, it should be good to go. |
@jrichter1 We should put our build script to git as well, so we can fix them at the same time. |
@jrichter1 this also opens opportunity to create shell script or app to uninstall on mac and put it next to installer inside dmg. |
Fix changes packaging to dmg for mac and updates README.md to mention new format for macOS installers.
@jrichter1 I've tested installation for bundled installer and it worked for me, should we merge this PR? |
It seems I'll need to change the way system tests launch on mac. I'm going to push it here and that should be enough to merge. |
looks like we are good to go |
Fix #1158 .