WIP: Crw-3071Use same arguments in all build scripts #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickboldt
reviewed
Jun 27, 2022
| '-v') CSV_VERSION="$2"; shift 1;; | ||
| '-b'|'--crw-branch') MIDSTM_BRANCH="$2"; shift 1;; # branch of redhat-developer/devspaces/pom.xml to check as default CHE_VERSION | ||
| '-v') CSV_VERSION="$2"; DS_VERSION="${CSV_VERSION%.*}" shift 2;; | ||
| '-b') MIDSTM_BRANCH="$2"; shift 2;; # branch of redhat-developer/devspaces/pom.xml to check as default CHE_VERSION |
There was a problem hiding this comment.
indents are different on line 81 and 82.
please make sure that -v always means CSV_VERSION (x.y.z), not DS_VERSION / image tag (x.y) == -t
nickboldt
reviewed
Jun 27, 2022
| ./build/scripts/sync.sh -b ${MIDSTM_BRANCH} -s ${SOURCE_DIR} -t ${DSC_DIR} \ | ||
| --crw-version ${DS_VERSION} | ||
| ./build/scripts/sync.sh -b ${MIDSTM_BRANCH} -s ${SOURCEDIR} -t ${DSC_DIR} \ | ||
| -v ${DS_VERSION} |
There was a problem hiding this comment.
this should be -t for tag/DS_VERSION (x.y) not -v for CSV_VERSION (x.y.z).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Updates dsc scripts to use the same arguments as the rest of the devspaces build scripts (where possible)
WIP because there are corresponding changes that need to be made in jenkins so they can be merged at the same time.
What issues does this PR fix or reference?
https://issues.redhat.com/browse/CRW-3071