Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

issue-931: moveCursor fails on file with tabs #1007

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

issue-931: moveCursor fails on file with tabs #1007

wants to merge 1 commit into from

Conversation

djelinek
Copy link
Collaborator

Before submitting your PR, please review the following checklist:

  • CONSIDER adding a new test if your PR resolves an issue.
  • DO keep pull requests small so they can be easily reviewed.
  • DO make sure tests pass.
  • DO make sure any public APIs changes are documented.
  • DO make sure not to introduce any compiler warnings.

Before merging the PR:

  • CHECK continous integration of main branch is green.
  • CHECK pull request check job is green.
  • CHECK all pull request questions/requests are resolved.
  • WAIT till PR is approved by at least 1 committer.

@djelinek djelinek force-pushed the issue-931 branch 29 times, most recently from 82a7d07 to 2ebc638 Compare November 23, 2023 11:30
@djelinek djelinek force-pushed the issue-931 branch 4 times, most recently from f4677df to eaf1c9a Compare November 28, 2023 19:46
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 28, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@djelinek djelinek force-pushed the issue-931 branch 3 times, most recently from c853908 to a09c7fb Compare March 20, 2024 22:04
@djelinek djelinek added the bug Something isn't working label Mar 20, 2024
@djelinek djelinek force-pushed the issue-931 branch 11 times, most recently from 9eef75f to 44a86c6 Compare April 10, 2024 23:03
@djelinek djelinek linked an issue Apr 11, 2024 that may be closed by this pull request
[🚫 Bug] moveCursor fails on file with tabs #931
Open
3 tasks
@djelinek djelinek force-pushed the issue-931 branch 4 times, most recently from 288d80f to d51001d Compare April 18, 2024 08:57
urbanfly
urbanfly reviewed May 16, 2024
View reviewed changes
tests/test-project/src/test/editor/textEditor.test.ts Outdated
break;
}
}
const notification = notifications.find(async notification => { return (await notification.getMessage()).startsWith('Codelens action clicked'); });
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

find does not support async callbacks; this will return a "truthy", unresolved Promise for each notification.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch

@djelinek
issue-931: moveCursor fails on file with tabs
e1bacd5 
Signed-off-by: Dominik Jelinek <djelinek@redhat.com>

tmp

Signed-off-by: Dominik Jelinek <djelinek@redhat.com>

tmp

Signed-off-by: Dominik Jelinek <djelinek@redhat.com>

tmp

Signed-off-by: Dominik Jelinek <djelinek@redhat.com>
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 20, 2024

Quality Gate Passed Quality Gate passed

Issues
4 New issues
2 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.2% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@urbanfly urbanfly urbanfly left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
bug Something isn't working do-not-merge/work-in-progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[🚫 Bug] moveCursor fails on file with tabs
2 participants
@djelinek @urbanfly