asking / command can be separated on cluster redirect. #2713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this handles normal commands, but it doesn't handle the multi (exec or pipeline) cases. unsure if pipeline makes sense in the context of cluster because of this (i.e. can get exception in middle, and will have no idea which commands were executed). Handling pipeline might require a total rewrite. to handle multi, I think we will have to pass an optional chainId into the executeMulti(), and only set chainId if it's undefined. With multi, it either all executes or none of it executes, so an exception will be meaningful.
still unsure how we handle pipeline. I'd argue that pipeline cant work effectively in cluster.
|
already part of #2716 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this handles normal commands, but it doesn't handle the multi (exec or pipeline) cases.
unsure if pipeline makes sense in the context of cluster because of this (i.e. can get exception in middle, and will have no idea which commands were executed). Handling pipeline might require a total rewrite.
to handle multi, I think we will have to pass an optional chainId into the executeMulti(), and only set chainId if it's undefined. With multi, it either all executes or none of it executes, so an exception will be meaningful.