Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: comment before else and and #236

Closed
wants to merge 1 commit into from

Conversation

zweimach
Copy link
Contributor

This fixes errors when parsing comments and newlines before else clauses and decorated and bindings.

(let_declaration
(let_binding
(value_identifier)
(number))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 Looks like there's a comment missing right here before the decorator.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I just realized that after I made this PR. I think the _newline_and_comment node discards the comment in this particular position.

@zweimach zweimach closed this Apr 12, 2024
@zweimach zweimach deleted the newline-comment branch April 12, 2024 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants