RFC: EMI: Check for collisions when using updateWalk().

[JoseJX]

This forces a check for collisions when updateWalk is called. This fixes Timmy running through the legs of Guybrush on the beach in the set mib. I think it fixes the logs in the flume puzzle as well, but I need to finish with that PR first to be sure since they're not visible right now.

[klusark]

I guess we don't need this in Grim as no moving actors collide with Manny?

[somaen]

That depends, that monster/car-puzzle might be doing some collisions like that. But largely anyone that's not Manny, doesn't really move much at all in Grim. (Which is mostly true in EMI too, apart from the wandering tourists, Jimmy and perhaps the logs in the lava puzzle?).

[aquadran]

so we wait for testing this?

[klusark]

I wanted to wait for the log puzzle to be fixed first. I think it's still not visible (but I haven't checked).

[aquadran]

@klusark have you checked this?

[JoseJX]

We're still waiting on this for my fixes for rotation. I'm going to check some of the possible areas where this might be problematic in Grim too.

[aquadran]

what is status on this?

[klusark]

I think this one may have been superseded by #1108, but that needs to be confirmed.

[chkr-private]

This bug is still present:

• as described in this PR, when Timmy moves on the beach of Monkey Island, there is no collision with Guybrush
• another instance of the bug is EMI: Guybrush walks through tourist body #1153

#1108 only fixed the issue if an actor is moved via Actor::setPos().

Unfortunately, the proposed bug fix has the drawback that the moving actor does not try to avoid the object it collides with. This has the following two consequences:

1. if Timmy tries to run into the direction of Guybrush (but can't because he would collide), then he hops up and down until another walk attempt with a random direction is initiated by the lua code and allows him to move
2. when testing EMI: Guybrush walks through tourist body #1153 something similar happens

• first place Guybrush on the right side of the tourist in front of the statue and try to talk with the tourist
• Guybrush tries to move to the left side (there is a fixed point he is supposed to walk to), but he collides with the tourist
• regardless if the code would avoid walking at all (as done in this patch) or with a modified patch where the actor would walk at least the returned amount from handleCollisionWith(), Guybrush would not move, but keep playing the walking sequence forever

[somaen]

Missing a space after if.