This repository has been archived by the owner on Jun 8, 2022. It is now read-only.
RFC: EMI/GRIM: Fix segfault when font isn't specified. #961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If the game scripts never call it it should probably be an error, and not try to recover as it will make it seem like it's functionality the game needs. |
|
If you call MakeTextObject from the retail game without specifying a font, it does work though, here it just segfaults. I suppose it's sort of the same issue for the default color (white), but again I don't think the scripts call it without setting that variable either. I guess the question is whether to reproduce the original behavior, or just write what the game requires. |
aquadran
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't think this segfault is reachable from the game scripts, but I noticed it while working on font issues.