New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Examine file ctime when checking if files have changed. #2212
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
Enhancement: Use ctime when checking for file changes | ||
|
||
Previously, restic only checked a file's mtime (along with other non-timestamp | ||
metadata) to decide if a file has changed. This could cause restic to not notice | ||
that a file has changed (and therefore continue to store the old version, as | ||
opposed to the modified version) if something edits the file and then resets the | ||
timestamp. Restic now also checks the ctime of files, so any modifications to a | ||
file should be noticed, and the modified file will be backed up. The ctime check | ||
will be disabled if the --ignore-inode flag was given. | ||
|
||
If this change causes problems for you, please open an issue, and we can look in | ||
to adding a seperate flag to disable just the ctime check. | ||
|
||
https://github.com/restic/restic/issues/2179 | ||
https://github.com/restic/restic/pull/2212 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,7 @@ | ||
package archiver | ||
|
||
import ( | ||
"bytes" | ||
"context" | ||
"io/ioutil" | ||
"os" | ||
|
@@ -576,6 +577,19 @@ func TestFileChanged(t *testing.T) { | |
save(t, filename, defaultContent) | ||
}, | ||
}, | ||
{ | ||
Name: "new-content-same-timestamp", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Table-driven tests are awesome, easily extendable for contributors! :) |
||
Modify: func(t testing.TB, filename string) { | ||
fi, err := os.Stat(filename) | ||
if err != nil { | ||
t.Fatal(err) | ||
} | ||
extFI := fs.ExtendedStat(fi) | ||
save(t, filename, bytes.ToUpper(defaultContent)) | ||
sleep() | ||
setTimestamp(t, filename, extFI.AccessTime, extFI.ModTime) | ||
}, | ||
}, | ||
{ | ||
Name: "other-content", | ||
Modify: func(t testing.TB, filename string) { | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love the wording!