fetch_uri: Use memfd for writing #139
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the code uses a GMemoryInputStream for reading the compressed data that is fetched using libcurl, which does not have seeking semantics, identical to those of lseek() (i.e. reading past the end results in a hard error). Seeking is needed to make libarchive use the seeking decompressor for ZIP archives, because that is the only way it will read the central directory and get the correct file attributes. This commit replaces the memory stream with a memfd for reading and a memfd-backed GUnixOutputStream for writing. libarchive/libarchive#1106 Fixes #136 Change-Id: Ifdf2e2aef448c9140d9330d6b9a4a754c519df5d
|
Well, seems that this will only work on RHEL 8, because the glibc wrapper for |
|
Feel free to reject and steal ideas. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the code uses a GMemoryInputStream for reading the compressed
data that is fetched using libcurl, which does not have seeking
semantics, identical to those of lseek() (i.e. reading past the end
results in a hard error). Seeking is needed to make libarchive use the
seeking decompressor for ZIP archives, because that is the only way it
will read the central directory and get the correct file attributes.
This commit replaces the memory stream with a memfd for reading and a
memfd-backed GUnixOutputStream for writing.
libarchive/libarchive#1106
Fixes #136
Change-Id: Ifdf2e2aef448c9140d9330d6b9a4a754c519df5d