Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

design ideas #3

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

design ideas #3

wants to merge 2 commits into from

Conversation

nleanba
Copy link

@nleanba nleanba commented Feb 19, 2022

No description provided.

@retog
Copy link
Owner

retog commented Mar 4, 2022

Many thanks @nleanba! Your suggestions contain some nice improvements.

For now the changes are in https://github.com/retog/scuttlesaurus/tree/designsuggestions, I removed the reset.css as I'd rather not share a css among the components as this goes against encapsulation idea, also the concept of a reset.css is questionable (see https://www.sitepoint.com/css-resets-useful-or-useless/). My change has no visual consequence afaict.

What should be changed before it can go into master is the action menu.
image
What doesn't convince me is the order of the elements, the permalink has just become much more prominent, also I find the indentation irritating.

@nleanba
Copy link
Author

nleanba commented Mar 5, 2022

the indentation is the same as the rest. I suspect your removal of the reset or some weirdness with web component styling has doubled the ident.

as for the order of the elements, I did not change it.

@retog
Copy link
Owner

retog commented Mar 5, 2022

as for the order of the elements, I did not change it.

I you removed the float: right that made the permalink appear on the right

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants