Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support for subscription based rate limit customization #561

Conversation

shadab14meb346
Copy link
Contributor

@shadab14meb346 shadab14meb346 commented May 8, 2024

Description

Fixes #562

This PR introduces the feature of API rate limit on tenantId basis. Earlier it was IP based.
The rate limit is descided based on the subscription of the account.
I have used the rate-limiter-flexible package to impliment the rate limiter.

Type of change

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link

vercel bot commented May 8, 2024

@shadab14meb346 is attempting to deploy a commit to the OpenInt Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

github-actions bot commented May 8, 2024

Thank you for following the naming conventions for pull request titles! 🙏

@shadab14meb346 shadab14meb346 changed the title Feat/subscription based rate limit customization feat: support for subscription based rate limit customization May 8, 2024
@shadab14meb346 shadab14meb346 marked this pull request as ready for review May 10, 2024 16:34
@jatinsandilya jatinsandilya self-requested a review May 12, 2024 13:23
Copy link
Contributor

@jatinsandilya jatinsandilya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a couple of comments

Copy link

vercel bot commented May 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
revert-client ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 14, 2024 2:08am

Copy link
Contributor

@jatinsandilya jatinsandilya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Will merge soon 🔥

…nd default rate limit environment is missing
@jatinsandilya jatinsandilya merged commit f8d105b into revertinc:main May 15, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants