Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop support for ruby 2.6 and test jruby #353

Merged
merged 3 commits into from
Mar 22, 2023
Merged

Conversation

seuros
Copy link
Contributor

@seuros seuros commented Jan 28, 2023

Summary

We are currently testing support for Ruby 2.6 to ensure compatibility with JRuby. However, JRuby now supports versions 2.7 to 3.1. I think upgrading the support to at least Ruby 2.7, which is nearing its end-of-life. Or even go directly to 3.0.

@keithdoggett , I want to give some maintenance shot to the repos.
Can you enable ci for my pr ?

@seuros seuros marked this pull request as ready for review January 28, 2023 13:08
@keithdoggett
Copy link
Member

Hey @seuros thank you for doing this and appreciate your help with the projects!

@keithdoggett
Copy link
Member

@seuros this issue with jruby popped up on other RGeo gem's CIs. It seems like if we use jruby head there's some bug in an implementation and a loop doesn't work as expected. I didn't look into it too much but the failing CIs show where the bug is occuring.

I'm not too familiar with JRuby, but I might have some time to look into this issue in a few days.

@seuros
Copy link
Contributor Author

seuros commented Jan 30, 2023

@keithdoggett i can look into it.

ps : jruby is easy, you need to drink lot of coffee while doing ruby.

@keithdoggett
Copy link
Member

@seuros thanks! I got busy this week but should have some time soon if you can't get around to it either.

@keithdoggett
Copy link
Member

Hey @seuros checking back in on this. It appears there was a bug in jruby-9.4.0.0 that was causing the issue. I just tried locally with the latest version (9.4.2.0) and it works. Can you push or re-run the tests so we can ensure that it is working on the CI as well then we can merge everything.

Thanks!

@seuros
Copy link
Contributor Author

seuros commented Mar 22, 2023

Yes

Copy link
Member

@keithdoggett keithdoggett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution @seuros

@keithdoggett keithdoggett merged commit 4df2796 into rgeo:main Mar 22, 2023
@seuros seuros deleted the rubyeol branch March 22, 2023 00:14
@seuros
Copy link
Contributor Author

seuros commented Mar 22, 2023

I have few more pr to open

@keithdoggett
Copy link
Member

Awesome looking forward to it. If you need help with any of them let me know

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants