-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
drop support for ruby 2.6 and test jruby #353
Conversation
Hey @seuros thank you for doing this and appreciate your help with the projects! |
@seuros this issue with I'm not too familiar with JRuby, but I might have some time to look into this issue in a few days. |
@keithdoggett i can look into it. ps : jruby is easy, you need to drink lot of coffee while doing ruby. |
@seuros thanks! I got busy this week but should have some time soon if you can't get around to it either. |
Hey @seuros checking back in on this. It appears there was a bug in jruby-9.4.0.0 that was causing the issue. I just tried locally with the latest version (9.4.2.0) and it works. Can you push or re-run the tests so we can ensure that it is working on the CI as well then we can merge everything. Thanks! |
Yes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the contribution @seuros
I have few more pr to open |
Awesome looking forward to it. If you need help with any of them let me know |
Summary
We are currently testing support for Ruby 2.6 to ensure compatibility with JRuby. However, JRuby now supports versions 2.7 to 3.1. I think upgrading the support to at least Ruby 2.7, which is nearing its end-of-life. Or even go directly to 3.0.
@keithdoggett , I want to give some maintenance shot to the repos.
Can you enable ci for my pr ?