new role for changing engine from local to remote db #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…al to remote database - first it runs role ovirt-engine-db-dump for dumping databases and get db variables - then it runs role ovirt-engine-remote-db to create databases and import data - at last it sets configuration on engine to remote databases - in ovirt-engine-db-dump are path for dumps fixed and local directory can be added as parameter - examples for inventory and playbook created
StLuke
requested changes
Aug 24, 2017
roles/ovirt-engine-db-dump/README.md
Outdated
| @@ -21,6 +21,7 @@ Role Variables | |||
| --- | |||
| ovirt_engine_db_dump_dwh: [True, False] Dump also DWH database (default: False) | |||
| ovirt_engine_db_dump_start_services: [True, False] Start engine and DWH service after dump (default: True) | |||
| ovirt_engine_db_dump_local_dir: directory on local machine where to store files (default: angine_dump in playbook directory) | |||
| ------------ | ||
|
|
||
| Preinstalled engine with local DB. | ||
| Preinstalled clean operating system on remote server. |
There was a problem hiding this comment.
I would add el7/linux based operating system
| ovirt_engine_db_dump_start_services: False | ||
| ovirt_engine_db_dump_local_dir: "{{ playbook_dir }}/engine_dump" | ||
| when: ovirt_type == "engine" | ||
| - name: get engine variables from file |
There was a problem hiding this comment.
empty space between new tasks
- empty lines between tasks added - meta file added - description changed
StLuke
approved these changes
Aug 24, 2017
- 2 new containers added in containers-deploy, that are used for migration - new engine added to engine-cleanup - engine-deploy-local-db added - test of ovirt-engine-local-to-remote-db added to test-* - get ip of engine and database from proper variables in ovirt-engine-local-to-remote-db - reset added to ovirt-engine-local-to-remote-db
Signed-off-by: leistnerova <lucie.leistnerova@gmail.com>
tests/engine-cleanup.yml
Outdated
| ovirt_engine_db_host: "localhost" | ||
| ovirt_engine_dwh: true | ||
| ovirt_engine_dwh_db_host: "localhost" | ||
| ovirt_engine_dwh_db_host: "{{ engine_dwh_db_host | hostvars['remote_db_centos7']['ansible_default_ipv4']['address']) }}" |
There was a problem hiding this comment.
I believe the trailing ) in ['address']) here is causing the interpolation error
There was a problem hiding this comment.
Thank you, I have overlooked that. I will fix it.
|
|
||
| - include: engine-cleanup.yml | ||
| vars: | ||
| engine_db_host: "localhost" |
There was a problem hiding this comment.
when I move db from local to remote, then here in cleanup I should point to remote one then, no?
StLuke
reviewed
Oct 2, 2017
| ovirt_engine_dwh_to_remote_db: True | ||
| roles: | ||
| - ovirt-engine-local-to-remote-db | ||
| ``` |
There was a problem hiding this comment.
I would add example inventory as you are hacking around with ovirt_type var in it
|
|
||
| - include: engine-cleanup.yml | ||
| vars: | ||
| engine_db_host: "localhost" |
…ible into local_to_remote_db
leistnerova
force-pushed
the
local_to_remote_db
branch
from
93d566e
to
532616e
Compare
README.md
Outdated
| @@ -46,6 +46,7 @@ This host group is meant for virtual machines hosted by oVirt Engine. | |||
| * [ovirt-engine-config] | |||
| * [ovirt-engine-db-dump] | |||
| * [ovirt-engine-install-packages] | |||
| * [ovirt-engine-local-to-remote-db] | |||
There was a problem hiding this comment.
Please mention new test under Test section, on line 105.
lukas-bednar
approved these changes
Oct 18, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it combines roles ovirt-engine-db-dump and ovirt-engine-remote-db to do the changes