Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Harika #26

Open
wants to merge 5 commits into
base: sprint-2
Choose a base branch
from
Open

Harika #26

wants to merge 5 commits into from

Conversation

harikapaluri
Copy link

@harikapaluri
Added request feature
9ba9ff6 
Allow donor's to request an interaction and store the request in the db
@harikapaluri
Used interaction Id and user Url in request Service
557cfea
@harikapaluri
Accept/Reject Feature
a945b1a 
View Pending Requestes/Accepted,Sending a mail to donor on acceptance/rejection
@jgkaplan
Copy link
Collaborator

Could you add validation for requests to the backend using express-validator? (An example is in the signup route) router.post( "/signup", [ body("firstname").notEmpty().trim().escape(), body("lastname").not().isEmpty().trim().escape(), body("email").isEmail().normalizeEmail(), body("password") .isLength({ min: 8 }) .withMessage("must be at least 8 chars long"), ], (req, res) => {...

@harikapaluri
Copy link
Author

@jgkaplan Yes Ill do that.

@harikapaluri
Update response status
758ea41 
FInd out exact email response
@harikapaluri
Added express validations
2864c64 
Added express validations
jgkaplan
jgkaplan approved these changes Aug 27, 2020
View reviewed changes
Copy link
Collaborator

@jgkaplan jgkaplan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have to remember to update the authentication code when we merge this in

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgkaplan jgkaplan jgkaplan approved these changes

@aimatmia aimatmia Awaiting requested review from aimatmia

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@harikapaluri @jgkaplan