Updates to work with Sinatra v2 #12
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
January 13, 2018 23:57
…adds flexibility.
|
@rkh could you kindly have a look at this PR and see if it solve the v2 compatibility issue? |
|
Changes look good, but I haven't touched this project in years and don't have anything running that I could try it out with. |
|
I forgot I'd done this! Maybe @kamaradclimber from issue #11 might have something to test against? Regards, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Konstantin,
This may or may not update the lib to work with v2 as I've not really acquainted myself with its changes, but the specs pass :) Let me know if there's a problem.
Regards,
iain