Use fontFeatures to extract OpenType features #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
can this option be optional? it super silly to embed 106mb of pure numpy just to extract features... 
@simoncozens I guess it must be possible to reduce dependencies for fontFeatures |
|
Probably, yes. It looks like the numpy dependency is coming in through beziers.py. I should rip out all the beziers/path related stuff from fontFeatures so that it only deals with feature code. |
|
that would be super! the first import of |
|
@typemytype I'm going to make |
|
fontFeatures 1.8.0 now has greatly reduced dependencies. |
|
@simoncozens verified, pyinstaller build went down from ~42MB to ~12MB. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #49