support ipv6

[zmlcc]

join host and port using net.JoinHostPort

Also add some changes include:
rename NetworkInfo.NetworkInfoIPv4 to NetworkInfo.NetworkInfo
rename NetworkInfo.ClusterAddrIPv4 to NetworkInfo.ClusterAddr
rename command flag public-ipv4 to public-ip
rename command flag private-ipv4 to private-ip
rename ROOK_PUBLIC_IPV4 to ROOK_PUBLIC_IP
rename ROOK_PRIVATE_IPV4 to ROOK_PRIVATE_IP

Description of your changes:

Which issue is resolved by this Pull Request:
Resolves #1629

[jbw976]

@zmlcc could you change this PR so that it would be merged into master instead of the 0.7 release branch? I think we'd only want this in master instead of putting it into an older release. Thanks!

[galexrt]

@zmlcc As @jbw976 wrote, can you please change the target of the PR to master.
If there is no response till Saturday, I'm going to pick up this PR to get this feature in.

[zmlcc]

Sorry for late response
I changed target to master and patch the code
Hope it works

[zmlcc]

Integration Tests Failed Because K8s 1.6.x DO NOT support CRD !!!

[travisn]

@zmicc support for 1.6 has actually been removed as of a couple days ago. If you fetch and rebase you should not see 1.6 in the builds anymore.

[jbw976]

@zmlcc that's correct, support for k8s 1.6 was removed in master recently. What's odd here is that you have that commit in your branch, which also removes k8s 1.6 from the integration tests, so the latest run of the integration tests should NOT have run on 1.6! I wonder if Jenkins did some caching or something and it doesn't support when the Jenkinsfile changes in the middle of a PR. I'm going to try to run it again and see what happens.

[jbw976]

Hmm, I started a new build (as opposed to replaying one) and it's still trying to include k8s 1.6 in the pipeline: https://jenkins.rook.io/blue/organizations/jenkins/rook%2Frook/detail/PR-1630/3/pipeline

The branch has the removal of 1.6 from the jenkinsfile, this must be some weird Jenkins caching:
https://github.com/ucloudlab/rook/commits/ipv6-support
https://github.com/ucloudlab/rook/commit/656d2233d744df898f4bad3feb2ad33a91aca293#diff-58231b16fdee45a03a4ee3cf94a9f2c3

[zmlcc]

@jbw976 I add one blank line in Jenkinsfile and it worked

[jbw976]

I've thought about this a little more and I think there is a backwards compatibility implication from this change. If there are pods out there that are using the old flags and env vars then after upgrading to this change the pods will crash with an error about unknown flags.

• --public-ipv4 flag
• --private-ipv4 flag
• ROOK_PUBLIC_IPV4 env var
• ROOK_PRIVATE_IP env var

I think we need some code in here that allows the old flags/env vars to still be used, but just copies their value over to the new locations.

We'd probably also want to add a note about this to the Deprecations list in the pending release notes: https://github.com/rook/rook/blob/master/PendingReleaseNotes.md

Does that make sense?

[travisn]

@zmlcc thanks for working on this, it will be great to get in. Any questions about the changes @jbw976 requested? This will help us ensure upgrades are compatible.

[zmlcc]

Delete origin branch by accident

[zmlcc]

I open new PR #1769 , let's continue to talk there