append new path to existing path in URI rather than replacing existing path - for 2.x #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, Could you show me how you are instantiating RSolr?
|
|
I agree that the existing behavior is broken and would like to see it fixed. This pull request needs tests, and it also would break backwards compatibility so it should be for release 2.x |
ndushay
changed the title
|
I am trying to spend time on Rsolr maintenance. Is this still an issue? If it can be re-based with no conflicts and a test added, I can commit some time to reviewing! It's too late to get it into 2.0 of course, and we're not looking at a 3.0 anytime soon... I don't fully understand the backwards compatibility issues... hmm. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am surprised how this has been working for others but it my case when the base url is "http://localhost:8983/solr" and my request handler is "/select", rsolr issues a request to "http://localhost:8983/select" rather than to "http://localhost:8983/solr/select".
I had to make this little change so that "select" gets appended to existing path "/solr" to result in "solr/select/" rather than overwrite "/solr" to result in "/select".