Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: config option to only send items after initial feed add #250

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

marcaurele
Copy link
Contributor

What

Added a new configuration option only-new so that when a new feed is discovered in the configuration, it will send or not the first run of the items found in the feeds.

Why

When using the tool in a docker image, and as a container batch job on a scheduler like Hashicorp Nomad, all new entries are only added through the configuration file. Therefore the option --only-new is not an option and it should be set through the configuration.

The idea is that when set to True, only items found in the feed after the initial add/run of the new entry will be emailed.

Copy link
Contributor

@auouymous auouymous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is it you can use the run command but not the add command?

test/test.py Outdated Show resolved Hide resolved
@marcaurele
Copy link
Contributor Author

marcaurele commented Jan 5, 2024

Why is it you can use the run command but not the add command?

I schedule the run command as a batch definition in Nomad, which has a schedule at specific time of the day. There is no easy way to run a unique special command in that case. I do not have access to the file system either, the config is defined in batch definition of the job.

I run it on a container orchestrator, not as a crontab on a server.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants