Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Emacs 29.3 to CI builds #495

Merged
merged 7 commits into from
Mar 31, 2024
Merged

Add Emacs 29.3 to CI builds #495

merged 7 commits into from
Mar 31, 2024

Conversation

matsl
Copy link
Collaborator

@matsl matsl commented Mar 24, 2024

What

Add Emacs 29.2 to versions used for the CI builds.

Why

Noticed when 29.3 was released that we had not included the previous
minor release in the versions we use to CI builds.

The docker image for 29.3 is not available yet so will add that later.

@matsl matsl requested a review from rswgnu March 24, 2024 22:22
@matsl
Copy link
Collaborator Author

matsl commented Mar 25, 2024

@rswgnu I think I understand now how to deal with the required build step build (28.1). I think that is set in the branch protection rules. Look under settings and edit the rules for the master branch. You should see required build steps there. We need to remove the build (28.1) from there.

I'm not allowed to touch these settings on your repository as things are setup now. Since these things are changed seldom I don't think I will need that authority if it is even possible to grant that. If you can fix that it would be great or we can pair on it during one of our sessions.

There is no silex docker image for 29.3 yet so that has to wait until that is added. (If it drags on I might raise a PR on that repo since it seems like an almost mechanical thing to add a new emacs version.)

@matsl matsl requested a review from rswgnu March 25, 2024 15:09
@matsl matsl changed the title Add Emacs 29.2 to CI builds Add Emacs 29.3 to CI builds Mar 26, 2024
@matsl
Copy link
Collaborator Author

matsl commented Mar 26, 2024

@rswgnu Since I wrote yesterday 29.3 silex docker image was added so I have bumped the version to 29.3. So if you can look into removing the build (28.1) branch protection rule so that the PR can be merged would be great.

@matsl matsl force-pushed the add_29.2_to_CI_build branch 3 times, most recently from 911a97c to 92be79b Compare March 31, 2024 16:50
@matsl
Copy link
Collaborator Author

matsl commented Mar 31, 2024

@rswgnu Did you save the removal of the required build-28.1?

@rswgnu
Copy link
Owner

rswgnu commented Mar 31, 2024 via email

@matsl matsl merged commit 07d70f8 into master Mar 31, 2024
4 checks passed
@matsl matsl deleted the add_29.2_to_CI_build branch March 31, 2024 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants