We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
auto-gen-only-exclude
When comparing the .rubocop_todo.yml file generated with:
.rubocop_todo.yml
rubocop --auto-gen-config --auto-gen-only-exclude --no-exclude-limit
versus
rubocop --auto-gen-config --auto-gen-only-exclude --exclude-limit=100000
the exclude section for Metrics/AbcSize is absent with the former and a Max value is given instead.
Metrics/AbcSize
Max
I would expect the two versions of .rubocop_todo.yml to be the same since the number of excluded files for Metrics/AbcSize is only 52.
Using the --no-exclude-limit option gives:
--no-exclude-limit
# Offense count: 69 # Configuration parameters: AllowedMethods, AllowedPatterns, CountRepeatedAttributes. Metrics/AbcSize: Max: 43
The problem only occurred when the offense count was 25 or above but it could be the number of excluded files is also a factor.
1.63.4 (using Parser 3.3.1.0, rubocop-ast 1.31.3, running on ruby 3.3.1) [arm64-darwin23] - rubocop-capybara 2.20.0 - rubocop-factory_bot 2.25.1 - rubocop-graphql 1.5.1 - rubocop-rails 2.24.1 - rubocop-rspec 2.29.2 - rubocop-rspec_rails 2.28.3
The text was updated successfully, but these errors were encountered:
[Fix rubocop#12888] Fix --no-exclude-limit for cops with Max conf…
094657f
…ig option
Merge pull request #12902 from Earlopain/max-with-no-exclude-limit
065fb23
[Fix #12888] Fix `--no-exclude-limit` for cops with `Max` config option
Successfully merging a pull request may close this issue.
When comparing the
.rubocop_todo.yml
file generated with:versus
the exclude section for
Metrics/AbcSize
is absent with the former and aMax
value is given instead.Expected behavior
I would expect the two versions of
.rubocop_todo.yml
to be the same since the number of excluded files forMetrics/AbcSize
is only 52.Actual behavior
Using the
--no-exclude-limit
option gives:Steps to reproduce the problem
The problem only occurred when the offense count was 25 or above but it could be the number of excluded files is also a factor.
RuboCop version
The text was updated successfully, but these errors were encountered: